hclsyntax: Pass marks through template expressions #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a template expression interpolates values which have marks, we should apply all of those marks to the output value. This allows template expressions to function like native cty functions with respect to marks.
azr
reviewed
Sep 23, 2020
| `hello%{ if false } ${target}%{ endif }`, | ||
| &hcl.EvalContext{ | ||
| Variables: map[string]cty.Value{ | ||
| "target": cty.StringVal("world").WithMarks(cty.NewValueMarks("sensitive")), |
There was a problem hiding this comment.
Howdy ! I was looking at this and nice !!! We are probably going to use that for Packer too :D.
Question: can an object or a list be sensitive ? I couldn't tell from the test here ex:
variable "foo" {
default = {
key = "secret"
value = "secret"
}
sensitive = true
}( maybe it would be worth it to tests that too if that should work )
There was a problem hiding this comment.
I think that's our hope, although it's very much work in progress. Applying marks to complex values currently doesn't work reliably, and this specific case (assuming your interpolation is like "key=${var.foo.key}") will currently panic.
I'll be opening a follow-up PR for that issue, and should be able to add an interpolation test case then. Thanks!
alisdair
deleted the
alisdair/pass-marks-through-expression-templates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a template expression interpolates values which have marks, we should apply all of those marks to the output value. This allows template expressions to function like native cty functions with respect to marks.